Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cmd+pkg): upgrade urfave and reorganize some code #491

Merged
merged 3 commits into from
Dec 31, 2024
Merged

refactor(cmd+pkg): upgrade urfave and reorganize some code #491

merged 3 commits into from
Dec 31, 2024

Conversation

rektdeckard
Copy link
Contributor

  • Upgrades urfave/cli
  • Relocates some shared utilities to pkg/
  • Adds some missing copyright headers
  • Updates load-test to use fancy tables like other commands do:
Screenshot 2024-12-30 at 8 36 52 PM

davidzhao
davidzhao approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, just a nit

cmd/lk/egress.go Outdated Show resolved Hide resolved
@rektdeckard rektdeckard merged commit 0c40021 into main Dec 31, 2024
3 checks passed
@rektdeckard rektdeckard deleted the tobias/deps-and-cleanup branch December 31, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

@frostbyte73 frostbyte73 Awaiting requested review from frostbyte73

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rektdeckard @davidzhao